-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hashbrown for std in addition to no_std builds #185
Conversation
It looks like @adam-rhebo hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
[clabot:check] |
It looks like @adam-rhebo signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
The thing is, we most likely want to use |
I see. Is |
Well, it is available with
I think it depends on your use-case: we want to use |
Personally, I am interested in an embedded use case where I expect fewer than 10 exports per module and hence This MR was really just motivated by simplifying the build system a tiny bit. Hence I'll retarget this to use |
Closing in favor of #187 |
This simplifies dependency management a little bit and might also yield minimal performance improvements for large modules even though the included benchmarks do not have enough exports to make this measurable.